Skip to content

Add new fragment inputs to maxInterStageShaderVariables:createRenderPipeline,at_over test#4541

Closed
ErichDonGubler wants to merge 1 commit intogpuweb:mainfrom
erichdongubler-mozilla:maxInterStageShaderVariables-new-fragment-inputs
Closed

Add new fragment inputs to maxInterStageShaderVariables:createRenderPipeline,at_over test#4541
ErichDonGubler wants to merge 1 commit intogpuweb:mainfrom
erichdongubler-mozilla:maxInterStageShaderVariables-new-fragment-inputs

Conversation

@ErichDonGubler
Copy link
Member

@ErichDonGubler ErichDonGubler commented Dec 22, 2025

Issue: #4540

Based on #4539.

Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@ErichDonGubler ErichDonGubler force-pushed the maxInterStageShaderVariables-new-fragment-inputs branch from d00cd2c to 5d2e671 Compare December 22, 2025 21:10
@ErichDonGubler
Copy link
Member Author

ErichDonGubler commented Dec 22, 2025

CI is caught on Error: Generated test variant would produce too-long -actual.txt filename. Not sure how to immediately resolve it, but 🫡 I'm hoping somebody will know better than I!

@ErichDonGubler ErichDonGubler changed the title Add new fragment inputs to maxInterStageShaderVariables:at_over test Add new fragment inputs to maxInterStageShaderVariables:createRenderPipeline,at_over test Dec 22, 2025
@ErichDonGubler ErichDonGubler force-pushed the maxInterStageShaderVariables-new-fragment-inputs branch from 5d2e671 to accd0f9 Compare December 22, 2025 21:55
@kainino0x kainino0x mentioned this pull request Jan 2, 2026
Closed
@ErichDonGubler ErichDonGubler mentioned this pull request Jan 9, 2026
Merged
8 tasks
@kainino0x kainino0x requested a review from greggman January 9, 2026 22:00
@kainino0x
Copy link
Collaborator

kainino0x commented Jan 9, 2026 •
edited
Loading

Sorry I didn't get a chance to look at this. Gregg could you TAL since you looked at this test in #4554?
(It's not the same as #4555/#4546 which are for a different test)

@kainino0x kainino0x mentioned this pull request Jan 9, 2026
Merged
8 tasks
greggman
greggman requested changes Jan 9, 2026
View reviewed changes
src/webgpu/api/validation/capability_checks/limits/maxInterStageShaderVariables.spec.ts
Copy link
Contributor

@greggman greggman Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you need to add the actual usages here? You'll also need to inject enable primitive_index and enable subgroups when appropriate.

@kainino0x
Copy link
Collaborator

kainino0x commented Jan 14, 2026

I've reviewed #4554 since it also added more exhaustive testing and there were some open issues with this one. Apologies Erich that neither of your PRs ended up getting landed! (though your changes the other PR did become part of my PR)

@kainino0x kainino0x closed this Jan 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@greggman greggman greggman requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ErichDonGubler @kainino0x @greggman